CRTSwitchRes options still missing for Rasperry PI as of 1.7.7

Alphanu · 22 August 2019 18:49

We need to show these options for the raspberry pi community. Most Raspberry Pi user do use this option and it is quite a big community.

Currently CRT options are hidden behind have_xrandr when it comes to Linux. This breaks CRT options for RPI as it does not utilise xrandr at all.

I have been unable to locate where and how these options are hidden and to be fair. In not really sure how we would want to move forward with hidding the options where you dont not want it.

@hunterk any ideas?

hunterk · 23 August 2019 21:33

I’m trying to get this pushed through. As we talked about before, I don’t think there’s any way to distinguish between RPi users and anyone else, so I guess we’ll just have to expose these options for everyone all the time.

hunterk · 29 August 2019 14:05

@Alphanu So, I believe this is the file where everything was added before:

github.com

libretro/RetroArch/blob/5dca2234cde04864389590a14f4ad31cd5382489/gfx/display_servers/dispserv_x11.c

/*  RetroArch - A frontend for libretro.
 *  Copyright (C) 2010-2014 - Hans-Kristian Arntzen
 *  Copyright (C) 2011-2017 - Daniel De Matteis
 *  Copyright (C) 2016-2019 - Brad Parker
 *
 *  RetroArch is free software: you can redistribute it and/or modify it under the terms
 *  of the GNU General Public License as published by the Free Software Found-
 *  ation, either version 3 of the License, or (at your option) any later version.
 *
 *  RetroArch is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY;
 *  without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
 *  PURPOSE.  See the GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License along with RetroArch.
 *  If not, see <http://www.gnu.org/licenses/>.
 */

/* We are targeting XRandR 1.2 here. */
#include <math.h>

This file has been truncated. show original

Do we need a separate file, since they’re not necessarily using X11? or do we just need to move some of those ifdefs? It appears some of them, at least, are still necessary, like the #include block.

Alphanu · 29 August 2019 15:37

So, for Linux pc this is all fine. Switching for the RPi is currently done in video_crt_switch.c , ideally it would need it’s own dispserv. Maybe via #ifdef have_videocore

The RPi build just needs the menu options exposed to start with. It does not use X or xrandr. Also for rpi4 it does not take advantage of videocore ATM. I think the lakka teams has this working.