Crt-guest-dr-venom-fast stopped working (1.9.1)

RetroArch Additions Shaders
#1

In the latest version the Shader crt-guest-dr-venom-fast stopped working. I have had no problems with others.

1 Like
#2

There is a bug in the smoothing.slang shader which got ‘activated’.

Correct smoothing.slang file in the crt/shaders/guest/fast is:

#version 450

/*
   Smart Smoothing Difference Shader
   
   Copyright (C) 2019 guest(r) - [email protected]

   This program is free software; you can redistribute it and/or
   modify it under the terms of the GNU General Public License
   as published by the Free Software Foundation; either version 2
   of the License, or (at your option) any later version.

   This program is distributed in the hope that it will be useful,
   but WITHOUT ANY WARRANTY; without even the implied warranty of
   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
   GNU General Public License for more details.

   You should have received a copy of the GNU General Public License
   along with this program; if not, write to the Free Software
   Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
   
*/

#pragma name SmoothPass

layout(push_constant) uniform Push
{
	vec4 SourceSize;
	vec4 OriginalSize;
	vec4 OutputSize;
	uint FrameCount;
   float STH;
} params;

#pragma parameter STH "Smart Smoothing Threshold" 0.7 0.4 1.2 0.05
#define STH params.STH
#define SourceSize params.SourceSize
#define COMPAT_TEXTURE(c,d) texture(c,d)

layout(std140, set = 0, binding = 0) uniform UBO
{
	mat4 MVP;
} global;

#pragma stage vertex
layout(location = 0) in vec4 Position;
layout(location = 1) in vec2 TexCoord;
layout(location = 0) out vec2 vTexCoord;

void main()
{
   gl_Position = global.MVP * Position;
   vTexCoord = TexCoord;
}

#pragma stage fragment
layout(location = 0) in vec2 vTexCoord;
layout(location = 0) out vec4 FragColor;
layout(set = 0, binding = 2) uniform sampler2D Source;

float df (vec3 A, vec3 B)
{
	float diff = length(A-B);
	float luma = clamp(length(0.5*min(A,B) + 0.25*(A+B) + 1e-8), 0.0001, 1.0);
	float diff1 = diff/luma;
	return 1.0 - clamp(7.0*(max(1.5*diff,diff1)-STH), 0.0, 1.0);
}

void main()
{
	vec2 dx  = vec2(SourceSize.z, 0.0);	
	vec2 dy  = vec2(0.0, SourceSize.w);	

	vec3 l1 = COMPAT_TEXTURE(Source, vTexCoord.xy -dx).xyz;
	vec3 ct = COMPAT_TEXTURE(Source, vTexCoord.xy    ).xyz;
	vec3 r1 = COMPAT_TEXTURE(Source, vTexCoord.xy +dx).xyz;
	
	float dl = df(ct, l1);
	float dr = df(ct, r1);
	
	float resx = dl; float resy = dr;
	
	FragColor = vec4(resx,resy,1.0,1.0);
}
1 Like
#3

Perfect!

In the flatpak version I had to use the administrator account, because the shaders folder is at the root. Thanks a lot!

1 Like
#4

I updated it in the slang repo, as well.

2 Likes
#5

And the ppa is already updated, in Flatpak you have to wait a bit. Thanks!

1 Like
#6

The normal version used to work on Android, then suddenly stopped working some time ago. Also it worked full speed then much slower (around 40 fps) before it stopped working completely (glsl), on a relatively powerful phone, Xperia XZ1 with Snapdragon 835 and Adreno 540 (more than 560 gflops performance). The fast version works there for the moment (around 150 fps at fast forward).

Edit: just tested vulkan on android, guest.r normal works at 90 fps, fast version fails to load.

Edit 2: after updating slang shaders now both work, and guest.r normal version works at 200 fps now.

1 Like