Crt-Royale Kurozumi Edition Help

c9f5fdda06 · 5 July 2018 14:07

I’ve been getting a bug whereby the top 1/2 of the screen has green bars. Doesn’t matter what core.

hunterk · 5 July 2018 12:47

Is that screenshot supposed to show it? because it looks fine to me.

c9f5fdda06 · 5 July 2018 13:56

Hi, hunterk

Yes. You don’t see vertical pinstripes at the top 1/2 of the screen?

hunterk · 5 July 2018 13:56

Ohhh, I see it now. It’s only visible on my crappy monitor from certain angles.

That said, I don’t know how the shader would cause that. Do any other shaders do it? What about non-kurozumi royale?

c9f5fdda06 · 5 July 2018 14:10

As far as I’ve tried, nothing else does this. crt-aperture, crt-geom, crt-lottes, crt-hyllian, etc they don’t do this. (I just deleted my shaders directory and re-downloaded the files but I get the same result).

Regular Royale doesn’t do this (OpenGL, btw)

NecroPoster · 5 July 2018 14:58

I’m not sure what exactly causes this but setting Mask - Type to 2 or Mask - Sample Mode to 1 fixes this.

Kurozumi · 11 July 2018 20:28

Oh boy that looks weird, i try to replicate that and see what’s causing it. On which Video Driver/Shader version does this happen?

c9f5fdda06 · 11 July 2018 21:42

Hi, Kurozumi. I use Driver: gl and GLSL shader inside the presets folder. As NecroPoster said, changing Sample mode to 1 fixes it but I’m not sure why.

Forscythe · 13 July 2018 00:59

So reading through this entire thread, can someone posts the recommended settings for a 4k display with this shader? Or is the current preset good enough? I’m confused if mask_triad_size_desired still needs a value of 3, and the convergence offsets require values of 0.

Kurozumi · 13 July 2018 10:53

@Forscythe : The thing is, Mask_triad_size_desired scales with the resolution itself. That’s what makes it a little bit tricky to make it look nice for everyone. So f.e. if you have a resolution of 800x600 a value of 3 would look way coarser as the same value on 1080p. On 1440p a value of 3 would give a again a higher TV line look than on 1080p, that goes on and on with the resolutions.

So the BVMs have a pretty high TV line count (the vertical mask pitch/subpixel lines), about 900 or 1000+ (Consumer TVs of the late 80s / 90s had 480, or later 600 tv lines), which makes a good aperture grille emulation almost impossible until you get pretty high resolutions, in this case 2160p or more.

The standard value of 1 is absolutely fine, even at 4k, but the most accurate one would be a value of 3 at that resolution. Especially on a pretty big 4kTV you would recognize the difference, on a 75inch TV it looks like this:

If you look closely you can see each scanline is made out of tiny little vertical lines, if you had a value of 1, you wouldn’t see it. That’s why i wrote wayback , on less then 4k i would use a value of 1, on 4k or more i would use 3 .

As for the convergence, the values that are in the shader should be pretty accurate. Every BVM i’ve seen, even if it was tweaked and calibrated to death, never had the 100% perfect convergence. The “signature thing” going on the BVMs (the ones i’ve seen; and macro screenshots often tell the same) if something white on 240p is displayed you almost always have a slightly green top and a magenta bottom, even if the convergence otherwise is spot on. The values that are in there will give you that.

It’s the same thing with diffusion and halation, the 1000 line 16:9 one doesn’t have much of it, but if you don’t turn it on at all, it makes the shader look artificial… It’s kinda a bit tricky to make it really “right”, and please everyone.

But in the end, hey, you gotta have fun, so edit it to your liking

@c9f5fdda06 (and maybe @hunterk ): I tried every renderer with every shaderversion i could. It has to be the combination of OpenGL and GLSL i guess, because if i recall correctly the slang version and the glsl version should be always the same. So if it breaks on slang, it should break on glsl, too.

The thing is, the only renderer i could choose the glsl version is gl, otherwise the shader file would not show, if i want to load it. But on all renderers the slang version works fine, that’s why i’m assuming what i’ve stated before, and why i think there’s something different going on.

I tried it with the regular royale, it’s broken too, you didn’t see it if you tried it, i know, but it seems it’s not the sample mode itself, it’s the halation weight. On regular Royale it’s off (if you turn it on one click, the same bug instantly appears), and what’s really weird about it, the bug scales vertically up and down with the TV lines you choose.

As far as a workaround for now, if i would be stuck on opengl, i would choose the cg version for now, or turn the halation value down to zero on your machine. My problem honestly is, i always try to help, if i can, and i could fix it sometimes or create workaround settings (when glsl and slang didn’t work right at all), but for the really weird stuff, @hunterk was “the hero”.

I’ll run some more tests, but at the moment i guess we search a needle in the haystack

Visor · 19 October 2018 01:50

Hello,

First I wanted to shout out a big thanks to Kurozumi and HunterK for all their great work on this truly beautiful shader.

Now on to my (very minor) problem… I’m trying to find the CG version of this shader but I’m not having any luck. I’ve downloaded the latest CG shaders update but even when I perform a search for “kurozumi” within the shaders_cg folder under Windows Explorer I can’t find any files related to this. That being said, I came across a separate “Quick explanation of shaders?” thread that HunterK responded to, in which he stated that CG is being depreciated, so is it possible that the CG version has recently been removed?

Thanks, Visor

hunterk · 19 October 2018 13:02

It’s still in the Cg shaders:

github.com

libretro/common-shaders/blob/master/cgp/crt-royale-kurozumi.cgp

# IMPORTANT:
# Shader passes need to know details about the image in the mask_texture LUT
# files, so set the following constants in user-cgp-constants.h accordingly:
# 1.) mask_triads_per_tile = (number of horizontal triads in mask texture LUT's)
# 2.) mask_texture_small_size = (texture size of mask*texture_small LUT's)
# 3.) mask_texture_large_size = (texture size of mask*texture_large LUT's)
# 4.) mask_grille_avg_color = (avg. brightness of mask_grille_texture* LUT's, in [0, 1])
# 5.) mask_slot_avg_color = (avg. brightness of mask_slot_texture* LUT's, in [0, 1])
# 6.) mask_shadow_avg_color = (avg. brightness of mask_shadow_texture* LUT's, in [0, 1])
# Shader passes also need to know certain scales set in this .cgp, but their
# compilation model doesn't currently allow the .cgp file to tell them.  Make
# sure to set the following constants in user-cgp-constants.h accordingly too:
# 1.) bloom_approx_scale_x = scale_x2
# 2.) mask_resize_viewport_scale = float2(scale_x6, scale_y5)
# Finally, shader passes need to know the value of geom_max_aspect_ratio used to
# calculate scale_y5 (among other values):
# 1.) geom_max_aspect_ratio = (geom_max_aspect_ratio used to calculate scale_y5)

shaders = "12"

This file has been truncated. show original

Visor · 21 October 2018 06:22

Hi HunterK,

Thanks; I ended up finding it under …\shaders\shaders_cg\cgp. For some reason my Windows 10 File Manager search option failed to find it, even though it had no problem finding the similar files under the shaders_glsl and shaders_slang folders. Very weird.

Do you recommend the best version of this shader to use, or are they all pretty much identical at this point? I have a GTX 1080 Ti so processing power wouldn’t be an issue.

Also, I’ve been trying to get these shaders to work on FBAlpha for rotated games. I’ve ensured that I’m using integer scaling for both axes. The result is very stripy and uneven as per the example in the link below:

[Album] Imgur

Is this working properly for you, or is this a known issue with rotated screens using FBAlpha?

Thanks, Visor

hunterk · 21 October 2018 19:12

Vertical games always look weird with it for some reason. I’m not really sure why. I use crt-hyllian instead, which can go vertical without looking wrong.

The Cg version has support for curvature, which I could never get working in the slang/GLSL versions, and the the GLSL version has a weird striping issue with one of the mask_sample_mode settings, but otherwise, they should be similar/the same.

Visor · 22 October 2018 23:48

Thanks; I’ve tried out the hyllian shader but I’m not a fan of the grid-like look. I’ll see if I can find some documentation or a forum thread somewhere as to how to turn off the grid.

torridgristle · 23 October 2018 18:22

In the shader set PHOSPHOR to 0.0 instead of 1.0, that ought to do it.

Visor · 23 October 2018 20:28

Hi torridgristle,

Thanks for the tip, although I can’t seem to get things working. I opened crt-hyllian.cg and found that most of the parameters were commented out (at least that’s what I think the hashtag/# in front of each command means?) There was a parameter called “#define PHOSPHOR 1.0” in the file so I changed it to 0.0 and tried running it with and without the hashtag, but it made no difference. Am I missing something?

hunterk · 23 October 2018 20:42

You don’t have to go in and do it in the shader. You should be able to change it on-the-fly using the runtime parameters menu. if you really want to change it in the shader, though, look for the line that looks like:

#pragma parameter PHOSPHOR "CRT - Phosphor ON/OFF" 1.0 0.0 1.0 1.0

and change that first 1.0 to 0.0, like this:

#pragma parameter PHOSPHOR "CRT - Phosphor ON/OFF" 0.0 0.0 1.0 1.0

Visor · 23 October 2018 21:01

Hi HunterK,

Sorry, but how do I access the runtime parameters menu?

Meanwhile, I made the change to the shader file as you demonstrated (at least temporarily until I figure out this runtime paramters stuff) and things are much more to my liking, thank you.

Also, I discovered under …\shaders\presets\FB Alpha that there were shader preset files for every game, for example dkong.cgp. I was able to set PHOSPHOR to 0.0 in there, but this is of course not very ideal as I don’t want to have to edit this for each individual game. I don’t want to set this for the core either, as I’m using crt-royale-kurozumi for all my horizontally-oriented arcade games.

Thanks, Visor

hunterk · 23 October 2018 21:05

With a game loaded, go back into the quick menu, then go to shaders > parameters and it will list all of the things you can change from the menu.

If you want to change it for all of the presets you already have, Notepad++‘s find-and-replace function has a “replace in all open files” option, so you could open all of the vertical games’ presets at once and then replace it in all of them at the same time.