New CRT shader from Guest + CRT Guest Advanced updates

1 Like

this is a base problem at original preset level, i think it might not have nothing to do with your prreset in this case sonkun, it might be my screen res or something

2 Likes

New Release Version (2024-09-15-r1):

Notable changes:

  • NTSC shaders optimizations, cleanup.
  • Improvements on NTSC coloring/rainbowing implementation.
  • Two new NTSC coloring/rainbowing modes.
  • Low-tap count behavior improved (NTSC).
  • Internal resolution option added to NTSC shaders, similar to the HD feature.
  • NTSC Sharpen changes to the ‘positive’ mode, now both modes dissolve dithering patterns, positive mode preserves more details. Use resolution scaling feature if missing the ‘old positive mode’.
  • Pre-scaler presets included in the ‘guest’ folder. They are optimized for prepending to crt presets. Usually regular scaler presets scale to viewport, which can be very slow and also excessive.
  • Most existing presets shouldn’t be affected (@sonkun), some testing is welcome anyway.

Download link:

https://mega.nz/file/tk4xFBCL#-3qo6saKm86uIAT9uF4jipKzvEX1uL3aOSSQVT6EWns

9 Likes

Example of tuned NTSC aperture preset, using new features:

  • horizontal pre-scaler
  • 8-taps
  • rainbowing
  • positive NTSC sharpen

12 Likes

it looks good. But what am I saying… every update is good!

1 Like

Nice. I knew that last update wasn’t going to be the final one. So right off the bat loading this update up with my go-to test game Sonic 1 I notice 2 things, first was that I noticed a speed increase, no more jankiness and dropping of frames, it’s full speed again using my rainbow presets. The second thing I noticed loading up one of my composite presets were these vertical lines in the water that wasn’t there previously:

I seemed to track it down to the “ntsc gamma correct” setting. It’s more severe after turning it up to 0.12:

After disabling it they dissapear:

I see the new rainbow options as well. Off first glance setting 1 seems to be the new iteration that you introduced in the previous update, setting 2 seems to be the older original iteration you first introduced and setting 3 seems to be a slightly different iteration of setting 1. Not sure which one I’ll end up sticking with at the moment but it’s nice to have more options to choose from.

3 Likes

Any chances to incorporate Noise options from PlainOldPants, please ?

2 Likes

Thanks for testing, seems like a regression indeed. I will give it my best later this day…

Edit:can you test this version?

https://mega.nz/file/Y5pCGJTT#wYFExF6r2V6eZ0W5P7CEvZzwXNTCrxt-d2P-sW5Vxm0

2 Likes

I’ll try it right now give me a sec

Edit: @guest.r Well that was a quick fix, no more vertical lines in the water:

3 Likes

New Release Version (2024-09-16-r1):

Notable changes:

  • NTSC shaders optimizations, cleanup.
  • Improvements on NTSC coloring/rainbowing implementation.
  • Two new NTSC coloring/rainbowing modes.
  • Low-tap count behavior improved (NTSC).
  • Internal resolution option added to NTSC shaders, similar to the HD feature.
  • NTSC Sharpen changes to the ‘positive’ mode, now both modes dissolve dithering patterns, positive mode preserves more details. Use resolution scaling feature if missing the ‘old positive mode’.
  • Pre-scaler presets included in the ‘guest’ folder. They are optimized for prepending to crt presets. Usually regular scaler presets scale to viewport, which can be very slow and also excessive.
  • Edit: luma fix with gamma corrections and adaptive sharpen (thanks @sonkun for testings).
  • Edit2: clamping bug fix

Download link:

https://mega.nz/file/wtJ1wYaa#9aSsJVQdgw_gxZiZ7eI6Qt8aFqQ9JMCt-WUuhZ4irnQ

7 Likes

No problem, glad I was able to help and thank you for the fast new release. I also smell a new sonkun pack in the making to go along with this update. Gonna take this to the lab and see if I can squeeze out a little more sharpness in my composite presets and further check out the new rainbow options.

4 Likes

Ok so upon trying out the new “positive” ntsc sharpness at a value of 10.00 with Sonic I noticed something strange, whenever I move Sonic forward or back and then stop a very small amount of pixels seem to “glitch” for just a few seconds. I only notice it in this small white area between his nose and eyes:

I tried to capture video footage of it:

This also happens if I load up the standard guest ntsc shader and change ntsc sharpness to 10.00 as well. That also doesn’t happen at all at -10.00.

2 Likes

Thanks for a keen eye and more testing. It seems it’s a precision error involved, but looks like it’s getting fixed. Found some more stuff to fix, so it’s getting there… :grinning:

2 Likes

Glad I could help. When you’re in the lab for hours at a time I guess even these small kind of things become noticeable and sticks out like a sore thumb when you’re constantly in and out of the parameter settings lol. I’ll be around to test any test packs you may have.

2 Likes

New Release Version (2024-09-16-r2):

Notable changes:

  • NTSC shaders optimizations, cleanup.
  • Improvements on NTSC coloring/rainbowing implementation.
  • Two new NTSC coloring/rainbowing modes.
  • Low-tap count behavior improved (NTSC).
  • Internal resolution option added to NTSC shaders, similar to the HD feature.
  • NTSC Sharpen changes to the ‘positive’ mode, now both modes dissolve dithering patterns, positive mode preserves more details. Use resolution scaling feature if missing the ‘old positive mode’.
  • Pre-scaler presets included in the ‘guest’ folder. They are optimized for prepending to crt presets. Usually regular scaler presets scale to viewport, which can be very slow and also excessive.
  • Edit: luma fix with gamma corrections and adaptive sharpen (thanks @sonkun for testings).
  • Edit2: clamping bug fix.
  • Edit r2: ‘glowing nose’ problem mitigation/fix, some code improvements.

Download link:

https://mega.nz/file/YwoGyZjY#5CnIna_bBCob553IvmhQtdoNu0hXSi5vg4cfipdSVys

7 Likes

Yup, tested it right away and that problem is gone. Ok I’m gonna continue playing around and report back if I find anything.

Edit: @guest.r On another note I’m noticing the difference between negative ntsc sharpness and the new positive ntsc sharpness. With negative values small details get blurred a bit more, here’s my current preset using -10.00 ntsc sharpness:

Here’s with 10.00 sharpness:

With positive values the details like Sonic’s nose (the little white dots on it) stand out a bit more along with the details on the bricks on the wall and the fire lamp/fire itself.

Same thing with 3-phase games. Current preset with -10.00 ntsc sharpness:

Positive ntsc sharpness:

Notice the outer left and right long vertical black line on the “Round 1-1” board.

It’s very intricate and minor, some may not even notice the difference but it definitely helps if you’re going for a more sharpened look.

2 Likes

Thanks for some good test cases. Personally, i was always getting mad at the FF5 menu text with 3-phase. :grin: But that’s really more a chroma issue. Adaptive sharpen currently works on luma only, but i guess it’s a good idea to try it with chroma too some day. :thinking:

Also a good solution would be tu run a multi-pass pattern checking shaders, very similar to the top dedithering solutions. I have narrowed it down to quite efficient lines of code, which still dissolve bars and checkerboards.

Dunno if it’s reasonable to look for complex solutions within these ntsc shaders, i guess there might be some possibilities left for improvements on the simple side, if something reasonable and decent shows up, i will sure update the shaders.

I also wanted to explain how lowering the number of taps also works as the chroma bleeding parameter would increase.

If number of taps is 16 out of total 32 (2-phase) then base bleeding value is already like 2.0, 4.0 becomes 8.0 etc. There is no need to crank 8 taps to 4.0, as it’s considered an extreme value and similar (like 16.0). This might only work with merge or s-video ‘presets’, just to mention it as the artifacted side effects are already mitigated as far it can go.

3 Likes

You’re welcome. If trying it with chroma will help to make an even sharper image then by all means try it out, preferably today lol.

This whole area caught me by surprise yesterday. I thought things would be simple using a “1 tap size fits all” approach, so far for my composite, composite rainbow and rf presets I had to switch up all my tap/phase combinations for each of them.

Here’s what I got for composite at the moment, this is my current preset from my pack:

Here’s what I’m working on:

Current preset:

New settings:

Even the water looks a bit different, seems more “blended”.

Current preset:

New settings:

Screen capturing rainbow images never seem to come out right but I’ll post it anyway, new rainbow settings:

Speaking of rainbows I have a request. Would it be possible to change the “rainbow effect” settings so that no matter which value you pick it auto disables itself when “3-phase” games are being played?

I ask because that rainbow setting benefits 2-phase games and doesn’t seem to be meant for use during 3-phase games at all. While technically it “does” also work with 3-phase games I noticed a difference between having that setting on and off.

Here’s how it looks with the rainbow setting on at a value of 1:

Here’s how it looks with it set to 0:

At first glance it might not look like a major difference but if you look close the diagonal rainbow artifacts look more pronounced with the setting off, the brick wall colors also seem to pop a bit more.

If by chance you can slip in a “auto deactivate 2-phase rainbows” switch whenever 3-phase games are being displayed it would be perfect.

Also if anyone wants to try out the new settings I’m working on simply load up one of my composite presets and change:

CRT Brightness: 0.40
Ntsc color saturation: 1.02 
Ntsc filtering gamma correction: 1.30 (1.32 Slot Mask only)
Ntsc taps: 6.00
Ntsc chroma scaling/2phase: 2.00
Ntsc chroma scaling/3phase: 3.00 (you need to edit this yourself in a editor, Parameter settings stop at 2.25) 
Ntsc sharpness: 10.00
Fsharpen strength: 0.50
Fsharpen contrast/ringing: 0.05
Fsharpen deblur: 1.00 (default)

For rainbow settings load up a rainbow preset then use the settings above with Rainbow Effect at 1.00 and “taps” at 13 with 3phase chroma/bleeding at 2.25.

@RetroGames4K you should check out these new ntsc sharpness settings. I think these are even better than the ones I told you about before.

5 Likes

New Release Version (2024-09-18-r1):

Notable changes:

  • NTSC shaders optimizations, cleanup.
  • Improvements on NTSC coloring/rainbowing implementation.
  • Two new NTSC coloring/rainbowing modes.
  • Low-tap count behavior improved (NTSC).
  • Internal resolution option added to NTSC shaders, similar to the HD feature.
  • NTSC Sharpen changes to the ‘positive’ mode, now both modes dissolve dithering patterns, positive mode preserves more details. Use resolution scaling feature if missing the ‘old positive mode’.
  • Pre-scaler presets included in the ‘guest’ folder. They are optimized for prepending to crt presets. Usually regular scaler presets scale to viewport, which can be very slow and also excessive.
  • Edit: luma fix with gamma corrections and adaptive sharpen (thanks @sonkun for testings).
  • Edit2: clamping bug fix.
  • Edit r2: ‘glowing nose’ problem mitigation/fix, some code improvements.
  • 09-18-r1: rainbowing now only works with 2-phase mode.
  • 09-18-r1: some general NTSC passes code improvements.
  • 09-18-r1: adaptive sharpen improvements, some artifact mitigation was also desired (2-phase).

Download link:

https://mega.nz/file/t4B3VIxI#GaQ8m5QCJjGOU7xlGTOXmyBerrKmce2gE0d36MwuxUI

10 Likes

This update came right on time. Testing it right away will report back soon.

3 Likes