Koko-aio shader discussions and updates

[kokoko3k]

Hi there estefan,

I was rethinking to the Wrap mode function i added a while ago and come to the conclusion that it is useless and maybe I started this mess by answering you the wrong way.
The right answer is “yes” there is an alternative way to do that.
bg_under_wrap_mode and bg_over_wrap_mode can take several values:

• “clamp_to_border”
• “clamp_to_edge”
• “repeat”
• “mirrored_repeat”

…and you set them in .slangp the same way you set any other parameter.

So my question is:
Is really needed to change the wrap mode as a runtime option in the shader?
Ditching it would free the code from some branching and complexity.
I’d ask you to try to set Wrap mode in koko-aio to default and use the retroarch’s builtin bg_under/over_wrap_mode instead.

If you’ll be able to do the same things as before, i’d cut that code from koko-aio.

[Starman99x]

Can you send the properly named files and properly edited slangp so I can take example from them? Because I’m still a bit confused about naming.

[estefan3112]

Hi again, @kokoko3k. I do not need a runtime option, although it is of course nice to test in real time. But no problem to edit that in the preset. In my use case, I will hardly ever head for a repeat option as it looks weird with real looking artwork. Best, Stefan

[kokoko3k]

@Starman99x Stripping the file paths for clarity, In slangp i used:

bg_over = “same-pre-string-as-other-$VIEW-ASPECT-ORIENT$_same-post-string-as-other.png”

The filenames i used:

• same-pre-string-as-other-VIEW-ASPECT-ORIENT-HORZ_same-post-string-as-other.png
• same-pre-string-as-other-VIEW-ASPECT-ORIENT-VERT_same-post-string-as-other.png

See? the only thing that can change is the BOLD TEXT

@estefan3112, right then, i’ll cut it off.

…done, i made another static option in config.inc:
// #define ALLOW_BG_IMAGE_TEXTURE_WRAP_IN_SHADER

That way you can easilly have the old functionalities by removing the leading “//” and it won’t impact performance as long as it stays commented.

[Starman99x]

koko please go easy on me I still don’t get it, what does this mean:

@kokoko3k

same-pre-string-as-other

and this:

@kokoko3k

same-post-string-as-other

If you can just provide a ready to use preset with properly named textures, I’ll be able to follow you more clearly.

[kokoko3k]

It means that text is common to both filenames. I literally use that filenames!

Just use that in place of your bg_over=xxxx (prepend the path ofc) and everything will work.

#reference “shaders_slang/bezel/koko-aio/monitor-slotmask-bloom-bezel-backimage.slangp” BG_IMAGE_OVER = “1.000000” DO_AMBILIGHT = “0.000000” DO_GLOBAL_SHZO = “1.000000” GLOBAL_ZOOM = “1.005500” BG_IMAGE_WRAP_MODE = “1.0” bg_over_wrap_mode = “clamp_to_border” bg_over = “shaders_slang/bezel/koko-aio/textures/same-pre-string-as-other-$VIEW-ASPECT-ORIENT$_same-post-string-as-other.png”

[Starman99x]

@kokoko3k

So, it you want to provide different textures by yourself and manage this externally, set the option to 0.0

This is what happens when I turn auto rotate image off:

Now the horizontal image is flipped wrong.

And the vertical image/texture still doesn’t show up when I rotate the display. Even after reloading the shader.

So I decided to give up on this and just make a separate slangp for rotated displays.

But if somebody is willing to help make this possible (to make an auto rotate preset), here are the files I used, so make something that works with them, and I’ll include it in the upcoming pack I’m making from @soqueroeu new designs.

Maybe there’s a better way to do things if we take a look at the “Updated vertical presets with automagical variables” by @Duimon I just couldn’t figure it out on my own (I’m still a newbie).

[kokoko3k]

It worked for me, weird. btw, maybe those new features deserve a thread to be explored deeply.

[HyperspaceMadness]

@Starman99x

But if somebody is willing to help make this possible (to make an auto rotate preset), here are the files I used, so make something that works with them, and I’ll include it in the upcoming pack I’m making from @soqueroeu new designs.

Hey, it’s cool you are enjoying working with this stuff

Keep in mind if you are doing your own packs and distributing them you need to be careful including graphics created by others to make sure you are getting their approval and following their licences.

This is important so we don’t inadvertently take away from the hard work and talent they have poured into these wonderful creations.

As an example of licenses, the graphics in both @Duimon’s and @TheNamec’s packs have a license which does not allow someone else to distribute them without permission, it could be the same with @soqueroeu’s unique creations.

[HyperspaceMadness]

Ok I created one:

Shader Preset Wildcards

This thread is a place to discuss the wildcards feature which can be used in retroarch presets. Preset Wildcard Path replacement allows you to have fewer presets while addressing many scenarios by changing paths in response to the retroarch state when the preset is loaded. An example would be having one preset which could be used with the entire list of images from the Bezel Project. The doc for the wildcards is here: Shaders - Libretro Docs

[Starman99x]

Roger that. As for Soqueroeu’s stuff I’m only making a pack for him which he himself will post if he wanted, he was kind enough to make the graphics for me upon request anyways. I just didn’t want to keep them for myself and I’m trying to make them utilize the features of koko-aio to the fullest.

[estefan3112]

Hi @kokoko3k - suddenly problems in Windows11/Geforce RTX 2070 during testing: All games show ugly and flickering pixel artifacts (see screenshot, tested also with today’s changes). The problem does not arise with the koko-aio version of my version 0.1 release (around January 29). It is independent of he presets used, so just switching back to the version 0.1 shader release removes the artifacts. Any idea how I could debug this??? Any hint appreciated, many thanks!

EDIT: Ok, it also occurs with your Commodore standard preset as well. Only Windows so far, no troubles on Macs and iPad.

[kokoko3k]

No problem, I’ve seen that in the past and fixed, I just need to test on nvidia myself.

-edit-
Found it, it is not (only) a matter of gpu, it is vulkan behaving a way versus glcore behaving the other, i’ve reproduced under intel and amd by switching from glcore to vulkan, didn’t yet on nvidia.

You can confirm the issue is the same by enabling ambient light with the commodore 1084s preset. Doing that should clear the glitches till i’ll fix it properly.

[estefan3112]

Correct! Enabling ambient light removes the glitches. Another reason to head for your most recent edits in the ambient light department .

[kokoko3k]

It should be fixed now.

[estefan3112]

Works - many thanks!

Sorry, another question to #define ALLOW_BG_IMAGE_TEXTURE_WRAP_IN_SHADER

After activation in config.inc, it seems that the default behavior in my own presets is not “mirrored repeat”, but “clamp to border”, which is a mystery to me. I have no special setting in my shader preset, but it nevertheless defaults to “clamp to border”. My presets reference from the “monitor-slotmask-bloom-bezel”-preset (today’s github revision).

Even if I like the result, I would like to understand why this is so…I thought that I would have to add this option to the preset, but it works from alone as well…no mirrored repeat any longer.

Many thanks!

[kokoko3k]

I did not changed anything and it is a mistery for me too, as it works as it should here!

[kokoko3k]

Exploring now the possibility to emulate a sort of dynamic contrast. When the global luminosity of the scene goes up, the global scene illumination goes down:

…to return to full brightness on darker scenes:

This is entirely implemented in the shader, no extra texture required, but i’m not 100% sure it would be useful and probably would need some tweaking (eg: the reflections should stay up).

In the worst case, i could keep the code to tweak the background luminosity as a user parameter.

What do you think?

[estefan3112]

Wow … but not yet ready for testing, right? Because I think that’s the effect of every Arcade hall … it an Arcade machine lightens up, the hall gets relatively darker… would be very interesting to see how it works out.

[estefan3112]

I am very sorry for the confusion: Some time ago, I did the following in config.globals.inc. line 200 #define BG_IMAGE_WRAP_MODE 1.0 That’s correct if I want that to be hardcoded?!? Thanks!