Setting aside any color/brightness issues, can someone please explain to me why this looks so clean? As I understand it, GDV-NTSC is basically just adding NTSC Adaptive to GDV, right?
Why am I having such a hard time getting GDV-NTSC to look similar, with clean edges and natural beam width variation? The white text on the blue background in SMB is killing me.
Megatron NTSC preset with a couple tweaks for 1080p.
You can tweak some settings a bit for a sharper look:
Setting both main gamma values to 1.0 and using blend mode 2.0 also does a nice job:
Greetings. I have been testing up your whole CRT guest advanced progress within the couple of presets you have already available.
I’d like to know it could ever be possible to add up within any of the current presets or a new one that could contain this particular effect known as Rainbow banding that was present on Sega Genesis console games. There’s a thread already talking about this:
For example in that particular reply, there’s a Sega Genesis demostration with RF connection which exposes the colorful red lines coming along with green and blue. The whole thread overall exposes different variants I did over time with public modded versions from mame_hlsl alone or with some few other presets like ntsc adaptive.
Would be great if that particular effect can be applied to other shader/presets that come along with composite-blurry looking just like some of you already have the capability of dithering presence. I unfortunately couldn’t find any other shader/preset that could apply accurately this effect just like it is for the real console.
Not to mention the fact such mame_hlsl preset along with others like tvout-tweak can allow to tweak intensity of the rainbow effect but also how specifically separate are each colorful line from each other, which helps out greatly in accuracy compared to the already existent NTSC shader/presets that to an extent deliver these Rainbow artifacts but in the same time far from being that accurate just like mame_hlsl.
I hope you can reply and thank you a lot for such a great job within your updated shaders.
Color issues aside that looks very good. Settings, please! 
you should be able to replace the ntsc-adaptive passes in guest’s presets with the ntsc passes from mame_hlsl with your settings in most cases.
Honestly quiet a few of MAMEs passes can be used with other presets. (At least like 3-4 off the top of my head.)
any ideas ? i may appreciate any preset you could know in how to mix those two passes with:
shader0 = "../crt/shaders/mame_hlsl/shaders/mame_ntsc_encode.slang"
filter_linear0 = "true"
wrap_mode0 = "clamp_to_border"
mipmap_input0 = "false"
alias0 = "NTSCPass"
float_framebuffer0 = "false"
srgb_framebuffer0 = "false"
scale_type_x0 = "source"
scale_x0 = "1.000000"
scale_type_y0 = "source"
scale_y0 = "1.000000"
shader1 = "../crt/shaders/mame_hlsl/shaders/mame_ntsc_decode.slang"
filter_linear1 = "true"
wrap_mode1 = "clamp_to_border"
mipmap_input1 = "false"
alias1 = "ColorPass"
float_framebuffer1 = "false"
srgb_framebuffer1 = "false"
scale_type_x1 = "source"
scale_x1 = "1.000000"
scale_type_y1 = "source"
scale_y1 = "1.000000"
ntscsignal = "1.000000"
shadowalpha = "0.100000"
avalue = "0.000000"
bvalue = "0.000000"
pvalue = "1.100000"
scantime = "47.700073"
notch_width = "3.450001"
ifreqresponse = "1.750000"
qfreqresponse = "1.450000"Here’s gamma 1.0/1.0, blend mode 2 with a few tweaks (mask strength 100%, etc). Looks fantastic! The edges and beam variation look very natural.
What settings did you use to produce the first screenshot you posted?
I used blend mode 2.0 and increased ntsc resolution. The downside is that it doesn’t blend dithering with games which use this technique, but should look very nice with nes… games.
Some posts above i replied that ntsc blending looks better with lower gamma and why 2.0 is defaulted instead of 2.4. Circumstances connected with bloom/glow passes which tend to share the same gamma value are such, that if glow/bloom/halation is used it looks quite different with low gamma. So 2.0 is a compromise, but 1.0 can be used np with presets which don’t rely on some lighting effects.
Is there any reference to the use case/intention of each mask option? Aesthetically I’m fond of mask 1 but I’m not 100% on when to use which options.
Hey,
masks are currently like WYSWYG and imo it shouldn’t be too hard to pick your fauvorite one or change some options.
Nevertheless, a short description:
-1.0: no mask
0.0: a dense magenta-green mask
1.0: Lottes RGB mask with a some sort of slotmask
2.0: Lottes RGB mask
3.0: Lottes - a bit enlarged and shifted RGB mask
4.0: Lottes - 2x enlarged and shifted RGB mask, looks nicer with 4k+
5.0: a dense magenta green mask (trinitron mask controls)
6.0: RGB mask (trinitron mask controls)
7.0: BW mask (trinitron mask controls)
8.0: BWW mask (trinitron mask controls)
9.0: magenta-green-black mask (trinitron mask controls)
10.0: RGBX mask (trinitron mask controls)
11.0: Red-Yellow-Cyan-Blue mask (nice for 1440p+)
12.0: Red-Magenta-Cyan-Green mask (similar to 11.0, but for BGR panel layout)
13.0: RRGGBBX mask (looks nice with 4k+)
Slotmask options are a bit more complicated to describe, it’s desired to match the slotmask width with the used regular mask width and then increase both strength values.
Some parameters are a bit self explaining i guess, don’t be afraid to experiment a bit…
Also note that if you change the “mask shift/stagger” value for a mask, it changes dramatically. For example mask 2 with stagger 1 looks similar to mask 3 with stagger 0, but a bit better for 480p content.
My monitor doesn’t like that pattern. The inversion artifacts are the most extreme I’ve ever seen:
What kind of monitor is that? That’s typically only a problem for very old displays, even a cheap 1080p work monitor shouldn’t have any such problems these days. EDIT okay so this can still be a thing on recent monitors, apparently, particularly the ones that boast 120+ Hz refresh rates.
Probably won’t help, but have you tried flipping the mask?
All LCD monitors have inversion artifacts. There doesn’t exist any LCD panels that don’t have it. What kind of artifacts depends on which inversion scheme the monitor uses. Mine (a 165Hz IPS) just happens to exhibit artifacts with that particular mask pattern, that’s all.
I don’t know what that means 
Just saying that the only time I’ve ever encountered anything like that was with a 10+ year old display. Guess I’ve had good luck in that regard.
try adding this line
mask_layout = "1.000000"Oh you meant BGR. No it doesn’t fix it. It reduces it a bit though.
Yeah that was a shot in the dark. IIRC the only way to eliminate it completely is to reduce the mask strength until the inversion artifacts go away.
I like to decrease the step value in the shader for some parameters, but when I do this the shader just quits (doesn’t get applied).
for example for bloom default is:
#pragma parameter bloom " Bloom Strength" 0.0 -2.0 2.0 0.05
#define bloom global.bloom // bloom effect
but when changing the step value to 0.01, like below, the shader doesn’t get applied any more:
#pragma parameter bloom " Bloom Strength" 0.0 -2.0 2.0 0.01
#define bloom global.bloom // bloom effect
this also happens with some other parameters, like bright boost dark pixels, lowering step value isn’t possible. In older shaders this used to cause no issues.
Any idea what’s happening? Above was tested with hires shader and vulkan driver.